search

hfaran / slack-export-viewer

A Slack Export archive viewer that allows you to easily view and share your Slack team's export
https://pypi.python.org/pypi/slack-export-viewer
MIT License
908 stars 192 forks source link

Messages not showing in channels #113

Closed phivk closed 4 years ago

phivk commented 4 years ago

the tool seems to run without errors (I also tried with --debug), and results in an accurate list of channels, but the resulting channels do not show any messages:

Screenshot 2019-11-09 at 3 47 24 PM

Running on Mac OS 10.14.6. I tried both latest Firefox and Chrome...

hfaran commented 4 years ago

What version of the tool are you using? Can you confirm that your archive has messages?

phivk commented 4 years ago

not sure how to check the version I have installed, but I installed on 9 Nov via:

pip install slack-export-viewer

I can confirm I have messages in the archive. I just noticed this error at the start of the command line log:

 * Running on http://localhost:5000/ (Press CTRL+C to quit)
ERROR:root:unable to find user in {'type': 'message', 'subtype': 'file_comment', 'text': '...'
brucehvn commented 4 years ago

I'm having the same problem with 0.9.5. I'm on ubuntu 18.04 LTR 64-bit. The problem happens with both Chrome and Firefox. When looking at the developer tools, there are no errors in the javascript console, but when choosing "select element", you can't get just the messages pane. The whole page is highlighted when hovering over the messages pane. Looking at the DOM in the developer tools, everything looks correct and the messages are there. Viewing the page source also looks correct so it might be some kind of CSS problem, maybe a viewport thing. I can't try with 1.0.0 because I have a different problem with that one (never ends up loading or bringing up the browser) which I will file a separate ticket for.

brucehvn commented 4 years ago

Ok, did a little more digging. The <div> tag with id messages, has a width style of: width: calc(100vw - 304px); This appears to be the problem child. If I changed that to a fixed width like 1000px, then the messages show up. On Firefox (71 64-bit), Chrome (79 64-bit), and Vivaldi (Chromium based, 2.9.1705.41 64-bit), if I change that style on the messages div to width: calc(100vw - 305px), the messages show up, so it appears to be a one pixel difference. Your value of 304 seems reasonable with the sidebar at 284px + 20 buffer, but for some reason it seems to need that extra 1 pixel of space.

brucehvn commented 4 years ago

Pull request #117 added to fix this.

hfaran commented 4 years ago

Resolved by #117

hfaran commented 4 years ago

Release 1.0.1 published