search

hfaran / slack-export-viewer

A Slack Export archive viewer that allows you to easily view and share your Slack team's export
https://pypi.python.org/pypi/slack-export-viewer
MIT License
908 stars 192 forks source link

Export never finishes loading [1.0.0] #116

Open brucehvn opened 4 years ago

brucehvn commented 4 years ago

slack-export-viewer 0.9.5 works, however I just updated to 1.0.0. Now when I run it, I get the following output in the console:

Archive already extracted. Viewing from /home/bruce/gitroot/python/slack-export/20190212-024929-slack_export...

and that's it. It never finishes loading and I don't get a browser window, etc. I've tried the --debug flag, but it doesn't output any other info. This is an unzipped data folder. While it's hung, hitting CTRL-C still kills it off. I've left it as long as 1/2 hour. 0.9.5 loads in about a minute.

Ubuntu 18.04.3 64-bit Python 2.7.15+

I tried both the installed version (pip install slack-export-viewer) and the master branch of the current github project.

hfaran commented 4 years ago

@brucehvn Can you walk through this with a debugger and test how far it gets? The only thing I have to test with is my test archive in this repo and that still works fine so I'll either need you to let me know where it's hanging or provide with me a sample archive that triggers this so I can reproduce it on my end.

DavidGerva commented 4 years ago

Hi @hfaran, I did a quick analysis because I have the same problem of @brucehvn. I face an execution stall (it never gets to launch the server) either extracting from zip or using the already extracted folder.

I think the problem is the def _build_threads(self, channel_data): function of the reader module. For very large channels the function takes a really long time, I don't understand if it can have in some cases an infinite loop.

This would also explain the "correct execution" reported by @brucehvn for version 0.9.5. If I find out more, I'll comment here.

puma10 commented 4 years ago

Same issue as well

thomasvandoren commented 2 years ago

This might be related to performance—it can take a very long time to parse through a large archive. If that was the root cause, this pr may help: https://github.com/hfaran/slack-export-viewer/pull/142