search

hfaran / slack-export-viewer

A Slack Export archive viewer that allows you to easily view and share your Slack team's export
https://pypi.python.org/pypi/slack-export-viewer
MIT License
949 stars 193 forks source link

allow attachment download from slackdump standard export #180

Closed limwz01 closed 8 months ago

limwz01 commented 8 months ago

Partially solves https://github.com/hfaran/slack-export-viewer/issues/156 by allowing attachment downloading from slackdump standard export (mattermost format not supported). Note that attachment downloading in the initial view (until a channel/group/dm/mpim is clicked) is not supported currently.

limwz01 commented 8 months ago

Future work is to not extract the attachments from the zip file at the beginning (saves a lot of loading time) and directly return a file stream for the required attachment when downloading.

limwz01 commented 8 months ago

I also had to remove the following line at some point: https://github.com/hfaran/slack-export-viewer/blob/39b6126e28a0f16289dc2222159863144662015b/slackviewer/archive.py#L74

kLy commented 4 months ago

Hey from what I can understand on this merge, attachments should now be visible after clicking on a particular chat on the left hand side? With 1.4.3 I'm still getting the same errors as before in #156

limwz01 commented 4 months ago

@kLy it's partially solved. image attachments will still not be visible in the chat view itself (I can't remember why right now), you need to click the broken image to download the attachment.

kLy commented 3 months ago

Ah gotcha! When I try that though I'm still getting a "500 Internal server error". In the console I get: FileNotFoundError: [Errno 2] No such file or directory: '/Users/redacted/path/D06U7JF8DSS/attachments/F0710EFFA92-image.png'

When checking the file structure itself, the file is situated at: '/Users/redacted/path/attachments/F0710EFFA92-image.png'

ie. directly under the export root, without "D06U7JF8DSS".

Thanks! :)

limwz01 commented 3 months ago

As I mentioned in the beginning, mattermost format is not supported

On Tue, Jun 11, 2024, 3:00 AM kLy @.***> wrote:

Ah gotcha! When I try that though I'm still getting a "500 Internal server error". In the console I get: FileNotFoundError: [Errno 2] No such file or directory: '/Users/redacted/path/D06U7JF8DSS/attachments/F0710EFFA92-image.png'

When checking the file structure itself, the file is situated at: '/Users/redacted/path/attachments/F0710EFFA92-image.png'

ie. directly under the export root, without "D06U7JF8DSS".

Thanks! :)

— Reply to this email directly, view it on GitHub https://github.com/hfaran/slack-export-viewer/pull/180#issuecomment-2159091088, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4BX5RVEALJKX2ALNOAPXEDZGXZWVAVCNFSM6AAAAABBSUQ4FCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGA4TCMBYHA . You are receiving this because you authored the thread.Message ID: @.***>