search

hfaran / slack-export-viewer

A Slack Export archive viewer that allows you to easily view and share your Slack team's export
https://pypi.python.org/pypi/slack-export-viewer
MIT License
957 stars 192 forks source link

Download pictures #44

Closed mario6097 closed 6 years ago

mario6097 commented 7 years ago

Hi

As far as I see, slack-export-viewer does not create code to see pictures on the local page, it renders only a link to the slack url of the picture, doesn't it? Indeed, it would be nice to have slack-export-viewer be able to download pictures in a local folder. Any chance to see a improved code (which is already indeed very useful, but could be even more useful) Thanks Cheers mario

hfaran commented 7 years ago

At this time, I unfortunately don't have time to implement this, but I absolutely welcome a PR from you if you're up to the challenge. :)

hfaran commented 7 years ago

Actually, this PR already added it I believe: https://github.com/hfaran/slack-export-viewer/pull/40 But it looks like the original contributor has left it. If you want to fix the couple comments I left on it, I will gladly accept it.

mario6097 commented 7 years ago

Hi hfaran, nope, unfortunately I have not an idea how to do it. Indeed, there is even something basic about Slack I do not get, see here