hfaran / slack-export-viewer

A Slack Export archive viewer that allows you to easily view and share your Slack team's export
https://pypi.python.org/pypi/slack-export-viewer
MIT License
939 stars 194 forks source link

Updated and refactored message rendering #78

Closed benwarfield-usds closed 5 years ago

benwarfield-usds commented 6 years ago

Work that was originally undertaken to update upload-preview and link-preview rendering, which expanded to handle more complicated bot-generated messages (from e.g. the Jenkins or Github bots), and culminated in some significant refactoring, in order to make it simpler to fix various rendering issues that were found in that process.

Commits in the branch are separated out as cleanly as seemed possible, to give some traceability, but at a high level:

benwarfield-usds commented 6 years ago

I tested with all the cases that I have available—one of the frustrations I had was that Slack appears to have changed their format and not to make it especially easy to figure out what changes have been made. So it's possible that I broke something that I wasn't able to test, but I did test this on several days worth of slack messages in several organizations with a few different bots attached.

It would be interesting to try to set up a workspace that has a a reasonable number (more than 100 and less than 10K) of messages in it, and just periodically re-export it to see what's changed and make sure everything still works—I'm not sure that's within my available capacity for this particular side-line, however.