hfg-gmuend / openmoji

Open source emojis for designers, developers and everyone else!
http://openmoji.org
Creative Commons Attribution Share Alike 4.0 International
3.96k stars 219 forks source link

Change the flags! #150

Closed OMGShay closed 3 years ago

OMGShay commented 4 years ago

If you want to know what flag emoji characters you need to change, please see below:

carlinmack commented 4 years ago

Wow!!! thanks so much, I'll get on this!

Laos Turkey Kazakhstan British Indian Ocean Territory and Diego Garcia Maldives Mayotte Jersey New Caledonia Namibia Iraq Hong Kong SAR China New Zealand Mozambique Niger Aruba Antigua and Barbuda Antarctica

carlinmack commented 4 years ago

First batch https://github.com/hfg-gmuend/openmoji/compare/3d28cf3377bfc8f7c8b9bc5a810d69dc14498273...7b1578527e3751ec4fa6abf72d3a752a1a589568

b-g commented 4 years ago

Hi @OMGShay, many thanks for spotting! This is great and actionable feedback! Keep in mind that our color palette and the level of detail is limited e.g. text on the flag is not really possible.

carlinmack commented 4 years ago

I think the text actually works even at 72x72 image

carlinmack commented 4 years ago

One restriction however is the white outline around the aruba star, can't find a way to make it look good so I've improved the background colour instead

b-g commented 4 years ago

Please no text. This also a question of "fairness" between different countries. Why does Mayotte get normal readable text but Saudi Arabia an abstraction. We spent weeks on the flags ... changing a basic assumption e.g. text y/n would be crazy hard in terms of effort. Please :)

b-g commented 4 years ago

@carlinmack May I reverse Mayotte https://github.com/hfg-gmuend/openmoji/commit/df0f1b3aa462f6e1eb1f38c6a872f2d1ac4244da ?

carlinmack commented 4 years ago

I feel like that implies Mayotte should also be an abstraction, rather than being removed (i.e. red line where the text is)

b-g commented 4 years ago

Yes abstracting this into a red line seems to be a "fair" compromise. ๐Ÿ‘ ! Good call!

mikiqex commented 4 years ago

I tried to fix the Czech flag, because my eyes bled from the narrow triangle :-) It should be halfway along the rectangle and to me it looks still better squished, than narrow. I also fixed colors.

I'm adding second SVG with correct proportions (3:2), but I understand if you prefer the 62 pt width to unify all flags. I tried to keep it's height, so I made the whole flag narrower (57 pt).

1F1E8-1F1FF.svg.txt 1F1E8-1F1FF_3x2.svg.txt

(Sorry for the .txt, It doesn't let me upload .svg. Also I'm n00b in pull requests and stuff... :-)

carlinmack commented 4 years ago

@mikiqex are you familiar with GitHub, would you like to do a PR? If not I can do it for you and credit you :)

Also I just looked at the real and our flag and I can't believe how off we are, thanks for fixing it!

carlinmack commented 4 years ago

Maybe I misread the first time but I'll do the PR for you :+1:

carlinmack commented 4 years ago

@mikiqex https://emojipedia.org/openmoji/12.3/flag-czechia/ :D

Michele0512 commented 4 years ago

Albania: please redraw completely if possible. I think it is currently by far the most problematic flag. The double-headed eagle is simplified to the point that looks like a chinese character. It is the only unrecognizable flag in the set. Some minor problems are being corrected for flags that are otherwise recognizable

carlinmack commented 4 years ago

totally agree and thanks for spotting! we can do something similar to https://openmoji.org/library/#search=1F1F2-1F1E9&emoji=1F1F2-1F1E9 but more detailed

wayne-shih commented 4 years ago

Re the list of flags to be changed...

Mind if I also add in Taiwan ๐Ÿ‡น๐Ÿ‡ผ 1F1F9-1F1FC ?

Changes needed โ€” make the sun bigger โ€” (potentially) separating out the rays from the core; might mean making the core smaller than official to allow for the rays to split out and align with the OpenMoji style... will have to play around with that

OpenMoji (as at v12.3.0) Apple Color Emoji Official
1F1F9-1F1FC.svg flag-for-taiwan_1f1f9-1f1fc Flag_of_the_Republic_of_China.svg

Happy to give it a crack and a PR if that's fine with yโ€™all :)

wayne-shih commented 4 years ago

for Mozambique ๐Ÿ‡ฒ๐Ÿ‡ฟ

Mozambique: Add a yellow star.

Reckon would also be worth to add in a white rectangle to symbolise the book

OpenMoji (as at v12.3.0) Apple Color Emoji Official Flaticon rendition
1F1F2-1F1FF.svg flag-for-mozambique_1f1f2-1f1ff Flag_of_Mozambique.svg flaticon

See the flaticon abstracted version as ref https://www.flaticon.com/free-icon/mozambique_555673

b-g commented 4 years ago

Hi @wayne-shih Many thanks for reporting and spotting!

Happy to give it a crack and a PR if that's fine with yโ€™all :)

Please! :)

carlinmack commented 4 years ago

when you're designing, please don't copy another provider and instead use the official flag as a reference, thanks!

SecularSteve commented 4 years ago

I made my own "Pre-Alpha" version of the last 2 just for a bit of fun. It's pretty hard to work with Inkscape when you can't properly mirror objects.

But anyways, if any of you can make them better, knock yourselves out. All that's really needed is the square feathers, claws and better heads for the Albanian flag:

1F1EE-1F1F4

1F1E6-1F1F1

I can't continue them myself at this moment, as I have other things to worry about...

new_flags_0.1_WIP.zip

shaurya1709 commented 3 years ago

Also the Indian flag appears broken in the font versions. In Firefox, the flag just looks as a big blue circle at small sizes

github-actions[bot] commented 3 years ago

๐Ÿ OpenMoji is on hold over summer (project maintainers are out of office until Oct 2021).

b-g commented 3 years ago

Closing. This seems to be done. Added the desire for improvement of Albania, British Indian Ocean Territory and Diego Garcia to the backlog.