search

hfg-gmuend / openmoji

Open source emojis for designers, developers and everyone else!
http://openmoji.org
Creative Commons Attribution Share Alike 4.0 International
3.84k stars 213 forks source link

Fix generating combined COLR/SVG fonts #458

Closed 999eagle closed 9 months ago

999eagle commented 11 months ago

This change should fix the combined COLR/SVG fonts as maximum_color by default outputs the generated font to build/Font.ttf instead of changing the font file passed as argument directly. With this change, the output file is specified directly.

Fixes #438

@b-g @RobertWinslow

b-g commented 11 months ago

Hi @999eagle, many thanks for this! Just ... I have a hard time to verify this, as I'm unfortunately not familiar with the nitty gritty details of the svg fonts. Sorry!

Hence @mavit @RobertWinslow could one of you please cross-check and confirm? (Or explain me how I could integrate this issue into our test suite?)

b-g commented 9 months ago

Hi @999eagle, hope you've had a nice summer! Could you please incororate PR #464 into this branch to test/verify whether your proposed fix doesn't fail the introduced font tests (basically runs npm test all green)? Thanks!

999eagle commented 9 months ago

I've rebased this PR on top of #464, so if the tests pass now, it should work correctly.

999eagle commented 9 months ago

I've regenerated all fonts locally and pushed the new colr0_svg and colr1_svg versions now. With this, npm test passes.

Edit: If you want all generated fonts instead of just those two you can cherry-pick https://github.com/999eagle/openmoji/commit/2a572873e65825fcb031f00239fd890e2ec90a25 onto this branch.

b-g commented 9 months ago

Hi @999eagle, many thanks for the COLR/SVG fix! Yay! 👍 🙏! Merged.