hfg-gmuend / openmoji

Open source emojis for designers, developers and everyone else!
http://openmoji.org
Creative Commons Attribution Share Alike 4.0 International
3.84k stars 213 forks source link

improve masked emoji appearence #473

Open sotha1 opened 7 months ago

sotha1 commented 7 months ago

I think the masked emoji can be confused with a smile or something else, it's a bit subjective, but here's my suggestion:

here's the original: 1F637_color and my one: 1F637_color (cópia)

i know that it's a weird drawing but that's a exemple of the emoji should look on my idea

b-g commented 7 months ago

Hi @sotha1, many thanks! Good call, yes your suggestions would definitely improve it, especially as other OpenMojis with masks eg. https://openmoji.org/library/emoji-E0AC-200D-2642-FE0F/ have a style like the one you suggested.

Could you go ahead and grab the src file and edit/improve it? :)

sotha1 commented 7 months ago

do you mean 'svg' with 'src'? if yep, of course, its on my way

sotha1 commented 7 months ago

here's it: (optimized svg) 1F637

b-g commented 7 months ago

Great! Here is some hyper specific feedback :) If we re-do the OpenMoji it would be nice to be really 100%. I hope you don't mind!

2023-11-10 at 14 05

OK? Please make sure to submit then the final file tested (-> https://openmoji-tester.glitch.me/) and a src svg which has the grid layer in it.

sotha1 commented 7 months ago

here is it. i tried to upgrade this points that you mentioned, and a little tweak too: 1F637 i don't know if you will like the detail: i remove the white line that you mentioned at the second point. if you prefer, i would add the white line again, before i test it.

b-g commented 7 months ago

Hi @sotha1, great improvements! No further comments :) Either do a pull request or upload the src file in this chat, please test the file beforehand with the https://openmoji-tester.glitch.me/. Cheers!

sotha1 commented 7 months ago

Hi @sotha1, great improvements! No further comments :) Either do a pull request or upload the src file in this chat, please test the file beforehand with the https://openmoji-tester.glitch.me/. Cheers!

hey, i found these errors:

Captura de tela de 2023-11-13 13-02-30 Captura de tela de 2023-11-13 13-02-47

do you know how to fix they?

b-g commented 7 months ago

@sotha1 this is hard to debug from remote :) Hence please use the original source file and copy your changes over. Please see also https://openmoji.org/styleguide/ and especially https://openmoji.org/styleguide/#submission I hope this helps.

sotha1 commented 7 months ago

sorry, i did resolve 2 of the 3 problems, and my last is this: Captura de tela de 2023-11-15 10-22-01

it's the only one that i doesn't got to resolve. if you can give me the trick, i will thank you so :D

b-g commented 7 months ago

Open the SVG and check that all elements e.g. rect, line, circle ... don't have any style attribute e.g. remove all style="some css code" the problem is that svg elements can be styled with dedicated attributes but also with inline css code encapsulated in a style attribute.