search

hfg-gmuend / openmoji

Open source emojis for designers, developers and everyone else!
http://openmoji.org
Creative Commons Attribution Share Alike 4.0 International
3.9k stars 217 forks source link

Update nodejs version #482

Open fgaz opened 9 months ago

fgaz commented 9 months ago

Nodejs 14 is end of life. I'd like to build with a supported node version, but I'm getting compile errors because of the four-years-old nan dependency:

npm ERR! ../../nan/nan_typedarray_contents.h: In constructor 'Nan::TypedArrayContents<T>::TypedArrayContents(v8::Local<v8::Value>)':
npm ERR! ../../nan/nan_typedarray_contents.h:34:43: error: 'class v8::ArrayBuffer' has no member named 'GetContents'
npm ERR!    34 |       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;
npm ERR!       |                                           ^~~~~~~~~~~

Updating node and other dependencies to current versions would be nice.

b-g commented 9 months ago

Sorry! This is not a low priority for us. Already hard to keep the beast going. Happy to get help a PR on this.