kirylchyk_added_flag_emoji_washingtonDC

hfg-gmuend / openmoji

Open source emojis for designers, developers and everyone else!

http://openmoji.org

Creative Commons Attribution Share Alike 4.0 International

3.9k stars 217 forks source link

kirylchyk_added_flag_emoji_washingtonDC #489

Closed Kirylchyk closed 7 months ago

Kirylchyk commented 7 months ago

As per opened enhancement ticket https://github.com/hfg-gmuend/openmoji/issues/467, adding a new emoji for Washington DC flag

b-g commented 7 months ago

Many thanks for this! But please change the aspect ration following the other flags. Also make sure that running npm run test-dev produces no errors, currently this is not the case.

Kirylchyk commented 7 months ago

Modified aspect ration and ran npm run test-dev. Got 55585 passing, 1 failed due to hexcode, but i think it's not an issue as I am adding non-standard emoji.

Thank you

b-g commented 7 months ago

Many thanks for the improvements! Close :) The stars seem to be distorted e.g. could you please fix them e.g. compare with https://en.wikipedia.org/wiki/Flag_of_Washington,_D.C. and the images below? Other than that, I think we are ready to merge.

2024-02-22 at 12 22

PS: I've fixed the hexcode issue, npm run test-dev is green now.

Kirylchyk commented 7 months ago

Thank you for your feedback. Sending the latest version for the approval.

b-g commented 7 months ago

Many thanks! Merged.

Kirylchyk commented 7 months ago

Thank you for your cooperation!