hfg-gmuend / openmoji

Open source emojis for designers, developers and everyone else!
http://openmoji.org
Creative Commons Attribution Share Alike 4.0 International
3.84k stars 213 forks source link

White Spots #493

Closed RealityRipple closed 3 months ago

RealityRipple commented 3 months ago

I've identified 24 emojis with white elements in the background of the glyph. In some cases, it seems more intentional and stylistic, but in all cases, it makes them feel out of place on colored or dark backgrounds.

I've split the list up into things I'm more certain about and less certain about:

This PR is not intended to be directly merged - it's more of a reference. Some of these emojis may be better served with a different approach than just removing the white spots entirely.

b-g commented 3 months ago

Dear @RealityRipple, many thanks for eagle eyes! I wasn't aware to this "side effect". I'm calling it a side effect, as we are working behind the scenes on making the openmojis finally work as well on a dark background e.g. see https://github.com/hfg-gmuend/openmoji/pull/231#issuecomment-643671423 ... hence we've iterated and tweaked all existing openmojis to be dark-mode-ready = so that we can automatically generate a white halo around it. You can test this by uploading an openmoji to our testing app ( https://openmoji-tester.glitch.me) and then running the 3. Check visually (for dark mode) test. Long story short ... we won't be fixing your findings, as these are necessary for the upcoming dark mode support. But if you feel energized, happy to get help on this. All the best.