Closed Kirylchyk closed 2 months ago
Thank you
For reference https://en.wikipedia.org/wiki/Flag_of_Alabama
@Kirylchyk Many thanks for this! Please run npm run generate-data-tables
and then npm run test-dev
. The problem was, that the line you've added to data/extras-unicode.csv
introduced additional columns. I fixed it, but would be nice not have to do it for every upcoming US subdivision flag :)
merged
After the merged ... I saw that the flag is slightly buggy ... please fix:
@Kirylchyk Many thanks for this! Please run
npm run generate-data-tables
and thennpm run test-dev
. The problem was, that the line you've added todata/extras-unicode.csv
introduced additional columns. I fixed it, but would be nice not have to do it for every upcoming US subdivision flag :)![]()
Thank you! Will double check next time
After the merged ... I saw that the flag is slightly buggy ... please fix:
![]()
Indeed, my bad, will create the PR with updates asap
@b-g opening PR to add Alabama flag
local test results -> i assume same issue as previous time
`varia@varia:~/Desktop/my_code_projects/openmoji$ npm run test-dev
55627 passing (1m) 1 failing
1) Data integrity openmoji.json Hexcode and emoji property matches in openmoji.json? 🏴 1F3F4-E0061-E0076-E007F property should be matching:
`