hfg-gmuend / openmoji

Open source emojis for designers, developers and everyone else!
http://openmoji.org
Creative Commons Attribution Share Alike 4.0 International
3.84k stars 213 forks source link

Adding Alabama flag #497

Closed Kirylchyk closed 2 months ago

Kirylchyk commented 2 months ago

@b-g opening PR to add Alabama flag

local test results -> i assume same issue as previous time

`varia@varia:~/Desktop/my_code_projects/openmoji$ npm run test-dev

openmoji@15.0.0 test-dev mocha --parallel --reporter min --invert --grep "production" test/*.{js,mjs} --openmoji-data-json $PWD/data/openmoji.json --openmoji-src-folder $PWD/src

55627 passing (1m) 1 failing

1) Data integrity openmoji.json Hexcode and emoji property matches in openmoji.json? 🏴 1F3F4-E0061-E0076-E007F property should be matching:

  AssertionError: expected '1F3F4-E0061-E0076-E007F' to equal '1F3F4'
  + expected - actual

  -1F3F4-E0061-E0076-E007F
  +1F3F4

  at Context.<anonymous> (test/data.js:30:44)
  at process.processImmediate (node:internal/timers:476:21)

`

Kirylchyk commented 2 months ago

Thank you

Kirylchyk commented 2 months ago

For reference https://en.wikipedia.org/wiki/Flag_of_Alabama

b-g commented 2 months ago

@Kirylchyk Many thanks for this! Please run npm run generate-data-tables and then npm run test-dev. The problem was, that the line you've added to data/extras-unicode.csv introduced additional columns. I fixed it, but would be nice not have to do it for every upcoming US subdivision flag :)

Screen Shot 2024-04-12 at 09 45 19
b-g commented 2 months ago

merged

b-g commented 2 months ago

After the merged ... I saw that the flag is slightly buggy ... please fix:

Screen Shot 2024-04-12 at 09 51 12
Kirylchyk commented 2 months ago

@Kirylchyk Many thanks for this! Please run npm run generate-data-tables and then npm run test-dev. The problem was, that the line you've added to data/extras-unicode.csv introduced additional columns. I fixed it, but would be nice not have to do it for every upcoming US subdivision flag :)

Screen Shot 2024-04-12 at 09 45 19

Thank you! Will double check next time

Kirylchyk commented 2 months ago

After the merged ... I saw that the flag is slightly buggy ... please fix:

Screen Shot 2024-04-12 at 09 51 12

Indeed, my bad, will create the PR with updates asap