search

hfg-gmuend / openmoji

Open source emojis for designers, developers and everyone else!
http://openmoji.org
Creative Commons Attribution Share Alike 4.0 International
3.95k stars 219 forks source link

ESM module #518

Open danchitnis opened 1 month ago

danchitnis commented 1 month ago

Hello, and thanks for the excellent work. Are there any plans to migrate the openmoji's npm module to ESM? It seems it is still using old style commonJS and require.

b-g commented 1 month ago

I'm afraid this is currently not planned. We simply don't have the resources to keep everything up to date. It is already tough to keep up with the emojis. Sorry!

danchitnis commented 1 month ago

If you keep this issue open, I will see if I can help add the ESM part.

b-g commented 1 month ago

That would be brilliant! Any help is very welcome. But be warned this is a lot to refactor, see scripts in folder /helpers/ :)

danchitnis commented 1 month ago

I will run a small-scale test, then, if it works, I will work on a PR. Joining esm with the existing code is a challenge because of all the npm and JS shenanigans, but let's take it step by step!

nataliakeniganti commented 1 month ago

A fix esm module?

danchitnis commented 1 month ago

A fix esm module?

ESM for browsers and bundlers such as parcel, vite, esbuild, etc

pasanflo commented 1 week ago

Hi @danchitnis, I'm a front-end dev with some experience in vitest if testing is needed,but I haven´t done anything similar to porting a project to EcmaScript Modules.

Feel free to get in touch if you need a hand with this, I'm willing to learn about migration to ESM.