search

hfslyc / AdvSemiSeg

Adversarial Learning for Semi-supervised Semantic Segmentation, BMVC 2018
504 stars 129 forks source link

inside for loop: i_iter >= args.semi_start_adv, should be opposite? #26

Closed ecemlago closed 5 years ago

ecemlago commented 5 years ago

Hi, Thanks for sharing your work!

In your code: if (args.lambda_semi > 0 or args.lambda_semi_adv > 0) and i_iter >= args.semi_start_adv:

as far as i understand, you want to check whether to train the generator with unlabeled data(so that lambda_semi or semi_adv should be larger than 0), and also you check if semi_start_adv is smaller than iteration number. If you do that, inside if case would be run just once. I think it should be i_iter <= args.semi_start_adv, so that once starting number of semi-adversarial training more than number of iterations that have been run, generator weights will be updated with adversarial loss and self thought learning?

Am I missing something?

I appreciate your answer, thanks! Ecem

ecemlago commented 5 years ago

ohh, sorry too much coffee! :) What you did is the correct one! Closing the issue.