Replace tinyxml and libxml2 with pugixml

hfst / hfst-ospell

HFST spell checker library and command line tool

Apache License 2.0

13 stars 9 forks source link

Replace tinyxml and libxml2 with pugixml #45

Closed bbqsrc closed 5 years ago

bbqsrc commented 5 years ago

At the request of @snomos, I have updated the XML handling to work on Debian with upstream packages, and pugixml was found to be the best fit for this purpose as it's small, easy to read API, great documentation and Just Works™ :smile:

This builds and runs on Debian (stable, testing, unstable), macOS (with MacPorts or Homebrew) and should probably build fine on Windows though I have no system with MinGW to test on at this moment.

flammie commented 5 years ago

it doesn't seem to work on travis yet?

bbqsrc commented 5 years ago

Yes, I am looking into it.

bbqsrc commented 5 years ago

So the versions included in Ubuntu LTS 14.04 and 16.04 do not include a .pc file and detecting existence of C++ stuff with autotools isn't working out for me at all. 🤷‍♂️