0.5.2 is not a proper release

bsiegert commented 3 years ago

Hi! pkgsrc maintainer here.

hfst-ospell 0.5.1 was a Github release with an official release tarball. For some reason, 0.5.2 is just a tag, so it does not show up under "Releases". In addition, the tarball does not contain the configure script, just configure.ac.

TinoDidriksen commented 3 years ago

https://github.com/hfst/hfst-ospell/releases/tag/v0.5.2 made a proper release.

There is no configure, and I don't want to distribute one: When building from source, one should build from actual source - autoconf generated files have a bad habit of bit-rotting, leading to many places having to work around ancient configure scripts. Much better to generate locally from configure.ac.

flammie commented 3 years ago

Surely uploading the tarballs from make dist must be easiest for all the distros, if some distro is silly enough not to make the default autotools generated tarball easiest to package can only blame themselves or just use the github-generated source-only zips or just git checkout...

TinoDidriksen commented 3 years ago

Surely uploading the tarballs from make dist must be easiest for all the distros...

OpenBSD port builds wholly replaces config.guess because it is known to bit-rot, and "In most cases, patching configure directly is a bad idea." and "Configure scripts are big generated files. They are an ideal hiding place for trojan horses, and this has indeed already happened in the past."
Debian guidelines say "This rebuilds all auto-generated files to the latest version and provides better support for porting to the newer architectures."
Fedora guidelines say "Often a package will contain code which was itself generated by other code. This often takes the form of configure files..." ... "It is suggested, but not required, that such code be regenerated as part of the build process."

There are very strong reasons against make dist. There are no particularly good reasons for it.

The only remaining reason for it that I can sort of see is when the configure.ac and Makefile.am files are tied to ancient versions of autotools, but that is not the case here - we have CI that tests multiple configurations, including bleeding edge and long term support.

chenrui333 commented 3 years ago

bump the version in this PR, https://github.com/Homebrew/homebrew-core/pull/62994

But I did notice the artifact name got changed a bit (just call it out)

TinoDidriksen commented 3 years ago

But I did notice the artifact name got changed a bit (just call it out)

Correct. Prior releases were not by me. I just uploaded the same .tar.bz2 that our build system produces, which is a cleaned up git clone.

chenrui333 commented 3 years ago

Got you, thanks for confirming it!

hfst / hfst-ospell

0.5.2 is not a proper release #52