Closed MattiasBuelens closed 10 years ago
Not sure if this will still be useful, but I thought I'd help fix some stuff and add some extra screens which we may still need to use (switch party around, teach Rock Climb,...).
Can you fix the typos (“Jotho” → “Johto”) and split the CSS changes to a separate pull request?
To consider:
(Note: “PC Misc” is intended to be just a temporary catch-all “screen” until the rest of the PC screens are added, so I wouldn’t worry too much about the rename.)
Damnit, I always get "Johto" wrong. Anyway, fixed!
It simply bothered me that the PC Misc screen had no image and thus showed an "image not found" placeholder. I don't think we'll need extra screens for the PC though, we don't want to help the trolls. :stuck_out_tongue:
Looks good, I'll merge it when the CSS is reverted.
But I am a troll! :frowning:
What's with the CSS? You'd rather have the image show up on hover than have it always there but transparent?
I just prefer pull requests to be as atomic as possible. :bookmark_tabs: I think any CSS changes should be discussed/committed/merged separately from screen additions/changes.
Fair point. I'll make a separate pull request for one small CSS bugfix.