hftf / coords

2 stars 1 forks source link

Added variability region. #44

Closed MattiasBuelens closed 10 years ago

MattiasBuelens commented 10 years ago
MattiasBuelens commented 10 years ago

I went with my interpretation on what variability should incorporate. If you had something (slightly) different in mind, feel free to elaborate. :smiley:

hftf commented 10 years ago

I like it, but I swear the feature seemed more… “useful” in my head. (Actually I started implementing this locally yesterday, except inside of list_overlaps to minimize code duplication.)

We probably should fix #31 – Update overlaps when a checkbox (or the example scenario) is clicked.

MattiasBuelens commented 10 years ago

I started in list_overlaps first as well, but then I ended up with a lot of variables in that function and I just pulled it into a separate function.

I had a look at #31 too while working on this, see my comment on that issue.

hftf commented 10 years ago

Now that I played with it a little, I’m kind of questioning why I thought this feature should even be “interactive.” It seems like somewhat of a wasted opportunity to make clicking on the canvas more “usefully” interactive (no good ideas yet, though).

What are the pros and cons of:

hftf commented 10 years ago

Merged in 75b50e1