improve Participant's eventhandler calls and called functions

hftl-ims-research / wonder

Public WebRTC Framework developed in the WONDER project featuring seamless inter-domain interoperability.

http://www.ict-openlab.eu/home.html

MIT License

2 stars 0 forks source link

improve Participant's eventhandler calls and called functions #16

Open jhamfler opened 9 years ago

jhamfler commented 9 years ago

eventhandler functions this.RTCPeerConnection.on****statechange in Participant.js can be optimized by using/reading evt.type in called functions instead of a static string

one example occurence:

https://github.com/hftl-ims-research/wonder/blob/master/src/libs/Participant.js#L466

use the callstack msc's in Wonder Alalyse - C.3 Alice ruft Bob an (Sicht von Alice) - Teil 2-n to figure out which functions need to be adjusted

sdruesedow commented 9 years ago

OK, agree --> less chances for typos. The "on****statechange" strings seem to relate 1:1 to the evt.types, right?

jhamfler commented 9 years ago

Yes, every type had the same name as the static string.