Open meling opened 8 years ago
Removing them will make the CI blind if there is no score objects submitted by the tests, and will return unknown/zero for most of the values showed to the user.
However if we remove it, the use in html files needs to be removed as well.
Ok, can you point me to the html code where this is relevant?
We should instead report missing JSON score objects as:
No score data found in log output. (Link to relevant documentation)
That way the test developer will be able to fix this.
We would loose the information shown below from the build results at the webpage as well by removing this.
Files used: https://github.com/hfurubotten/autograder/blob/master/web/js/resultloader.js Also need to update: https://github.com/hfurubotten/autograder/blob/master/web/html/teacherresultpage.html https://github.com/hfurubotten/autograder/blob/master/web/html/maincoursepage.html
The only place where they are used is here:
https://github.com/hfurubotten/autograder/blob/master/ci/deamon.go#L120
That is they are used only when there are no JSON score objects emitted.
Suggest to remove them (in my ci-refactor branch for now), unless there is a good reason to keep them. We should not encourage ad hoc use of Autograder.