search

hg-pyun / axios-logger

Beautify Axios Logging Messages
MIT License
173 stars 33 forks source link

Customizing logger function doesn't work, always uses global config logger #75

Closed Iiiggs closed 3 years ago

Iiiggs commented 4 years ago

printLog only knows about global configs:

function printLog (text: string) {
    getGlobalConfig().logger(text);
}

need to have it merge with provided config overrides

gurisko commented 4 years ago

That's a good catch. I opened a PR that should be fixing this. It seems like this deserves a minor release. What are your thoughts @hg-pyun ?

hg-pyun commented 4 years ago

@gurisko @liiggs Thank you for catch!, I will review your pull request soon.