Maybe add a flag to `calculateDistanceFromEdgeOfBoard` to include or not include the edge of the board

[hgducharme]

In magicbitboards.cpp we do the following:

// Subtract the edge of the board since it isn't considered a blocking square
int numberOfMoves = utils::calculateDistanceFromEdgeOfBoard(square, direction) - 1;

but maybe we can do

int numberOfMoves = utils::calculateDistanceFromEdgeOfBoard(square, direction, includeEdge = false);

[hgducharme]

Did this instead:

       int distanceToEdge = utils::calculateDistanceToEdgeOfBoard(currentSquare, direction);

        for (int i = 1; i < distanceToEdge; i++) { ... }

That is, the for loop enforces how far we traverse