search

hgeorgsch / armchar-swish

ArM character server implementation using Haskell and Swish
GNU General Public License v3.0
0 stars 1 forks source link

Inconsistent use of hasName/hasLabel/hasTitle #92

Closed hgeorgsch closed 2 years ago

hgeorgsch commented 2 years ago

The current example used hasLabel in lieu of hasTitle/hasName for saga and covenant, in order to benefit from the hasStringProperty property and corresponding reasoning rule. However, it still uses hasName for the character.

Clearly covenant and character should be handled uniformly.

hgeorgsch commented 2 years ago

An additional issue is that hasLabel should normally be a label of the class. We have introduced instanceLabel for the cases where the instance has its own label. By this logic, hasTitle/hasName should be instanceLabels.

hgeorgsch commented 2 years ago

We should change Saga to use hasTitle or hasName instead of hasLabel. Then we can close this issue.