hgiesel / anki_straight_reward

Escape Ease Hell!
https://ankiweb.net/shared/info/957961234
22 stars 4 forks source link

Multiple reviews since last sync? #17

Closed buster-blue closed 3 years ago

buster-blue commented 3 years ago

(I would've put this in discussions, but they're not enabled. Sorry about that.)

When a card is reviewed multiple times since the last time you synced to straight rewards, does the card get the straight rewards for every review, or for just one of them. I think only considering one review since last sync makes more sense (since later reviews aren't adjusted for earlier straight rewards, because they didn't get them) but I just wanted to ask, since the addon's behavior in this situation doesn't seem to be documented.

hgiesel commented 3 years ago

I implemented support for this. However it's not well tested.

buster-blue commented 3 years ago

You're right. It looks like this feature was added in November. I'm not good at reading Python, but the comments suggest that when there are multiple reviews since last sync, only the first of those reviews is considered for a straight reward until the next sync. That's pretty much what I was hoping for. Thanks! I'll keep in mind that it might be buggy.

hgiesel commented 3 years ago

And if you notice a bug with this, don't hesitate to report. I've always been meaning to test this, but I would have to stretch the test over 4+ days, which I didn't have the patience to do yet :)