search

hgiesel / closet

The Web Framework for Flashcards
https://closetengine.com
GNU General Public License v3.0
65 stars 6 forks source link

Three bug in occlusion #96

Closed BEST8OY closed 2 years ago

BEST8OY commented 2 years ago

Hello I found Three bug in browser. 1- Close Menu doesn't function 2- In browser If you select card and active occlusion mode you can see the occlusions but you can't do anything (add or delete occlusion boxes , ...). So if you want occlusion mode work in browser you should first select card then select field which contain occlusions then active occlusion mode. 3- When occlusion mode is active for a card in browser if you suddenly choose another card, the first card copies itself to second card.

I Hope i was able to elaborate issues properly.

kleinerpirat commented 2 years ago

Thanks for reporting these issues!

  1. Can't reproduce this. Clicking "Close Menu" closes the context menu for me :thinking:
  2. Peculiar. I'll have to investigate a bit.
  3. The rich text input is decoupled from the HTML editor to allow editing of occlusions. Right now, these inputs are only recoupled when the occlusion editor is closed. If you don't close it before switching notes, the field element isn't updated. This should be easy to fix with a hook.
BEST8OY commented 2 years ago

Thanks for reporting these issues!

  1. Can't reproduce this. Clicking "Close Menu" closes the context menu for me 🤔

Huh. First one was my misunderstanding. I thought "Close Menu" function was supposed to be exiting occlusion mode without saving changes. But now i think its function is closing the the menu containing "Close Menu" itself all along.😅

BEST8OY commented 2 years ago

@kleinerpirat Well, I tested your 2.1.52+fix branch of closet and the issues which I reported were fixed. I wanted to close the issue, but I felt it is better if you close it when the PR gets its approval.