search

hginit / hginit.github.io

hginit.github.io
https://hginit.github.io/
17 stars 11 forks source link

Responsive Design: Fix home navigation scroll #4

Open captn3m0 opened 1 year ago

captn3m0 commented 1 year ago

The scroll for the listing on the home page is not natural. It should instead be top-to-bottom on the homepage.

image
elidakirigo commented 1 year ago

hello!, I'd love to work on this issue if it's still open and un-assigned. thanks

captn3m0 commented 1 year ago

Feel free to pick this up [^1]. My suggested solution would be to:

  1. Create vertical variants of all homenav images
  2. Write additional styles for devices with display width <1000px to switch the images to a vertical layout.

See this image for example:

homenav-vertical-1

We do have sources for the original images, but they happen to be in an ancient CPT 9 format, which I can't open.

[^1]: General advice, for small issues like these is to avoid comments "claiming" the issue, and just file a PR instead.

elidakirigo commented 1 year ago

sure! i'll take a look

jlduchaney commented 2 weeks ago

Working on this for Hacktoberfest 2024!

captn3m0 commented 2 weeks ago

If you need any help with image conversions, do reach out.

jlduchaney commented 6 days ago

Hi @captn3m0! Will you have time to review my pull requests before October 31?

If you don't have the bandwidth, I completely understand. I would just like to know if this is the case, so I can pick a different repository to work on for Hacktoberfest. Thanks in advance!

captn3m0 commented 6 days ago

Yes.

Since there's only single-digit pages in the entire repo, they are quite easy to review for breaking changes and correctness. As long as you take care to avoid breaking the site, should be easy to merge.

jlduchaney commented 6 days ago

Thanks for the quick response. In that case, I'll continue working through the issues you've posted. Appreciate your time!