search

hgoebl / mobile-detect.js

Device detection (phone, tablet, desktop, mobile grade, os, versions)
http://hgoebl.github.io/mobile-detect.js/
MIT License
4.12k stars 892 forks source link

Firefox Mobile Registers as Phone on http://demo.mobiledetect.net/ but not in JS library #78

Closed gregelenbaas closed 6 years ago

gregelenbaas commented 6 years ago

Important Note

Before creating an issue, please note:

mobile-detect is just a kind of "satellite"-project. It uses the RegEx patterns of Mobile-Detect and generates JavaScript source code based on the code of its "mother"-project.

Missing patterns for particular devices cannot be added in mobile-detect.js, instead you have to create an issue in Mobile-Detect.

Please provide the User-Agent string, the manufacturer and the type of device (phone, tablet, tv, bot, ...).

I won't replicate your issue to Mobile-Detect!

It doesn't make any sense to change generated code. I hope you understand.

Issue

[x ] I've read above note and I'm quite sure I have a real issue with mobile-detect.js

Hi there,

Firefox mobile doesn't have a phone object returned from the md.phone() method.

The mobile-detect project works correctly when testing at http://demo.mobiledetect.net/ for user-agent: Mozilla/5.0 (Android 4.4; Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

This leads me to believe this is an issue with mobile-detect.js.

Thank you for your stewardship of this project!

gregelenbaas commented 6 years ago

So this is not actually an issue, my bad. The md.mobile() works for Firefox on Android just not the md.phone() which makes sense. Closing