Make resume stateless - Githubissues

zkrige commented 3 years ago

This allows to resume even if app has restarted

Chaphasilor commented 2 years ago

Hi, I have some comments about this:

Firstly, I would love to see this get merged in, so thanks for your PR! 😍
This would be really useful for longer downloads where either the retries run out because of server errors or the download gets killed for other reasons!
Secondly, I'm not sure just from looking at the code, does this support restarting the download with a custom filename, so if I started downloading a file and set the name to xyz (or even renamed it after canceling the download), could I resume that file, or does it only look at the content-disposition header? I think it will respect the custom filename, because that is used inside __getFileNameFromHeaders() if the correct options are set, but I can't be sure without testing it out (or asking :P)
Also, did you use some kind of formatter (e.g. Prettier)? There's a ton of whitespace diff that makes it hard to see the actual changes, I think it would be great if you could remove those changes for clarity 😁

hgouveia commented 2 years ago

Implemented on v2.1.0

zkrige commented 2 years ago

wow amazing - thank you!

hgouveia / node-downloader-helper