hgouveia / node-downloader-helper

A simple http file downloader for node.js
MIT License
253 stars 54 forks source link

Silence redirectURL output #84

Closed ginsm closed 2 years ago

ginsm commented 2 years ago

Hey there,

Is there any way to silence the redirectURL <url> <url> output? I looked around the README and code but couldn't quite find where it was coming from.

Thanks! :)

hgouveia commented 2 years ago

Hello @ginsm , I don't really understand what is the redirectURL output, since it shouldn't output anything, could you send me an example of this?

ginsm commented 2 years ago

Hey, thanks for getting back to me. That was my impression while reading the code as well -- I couldn't find anywhere that would cause such an output. Here's an example though:

image

And here's a gist containing the two files where I'm utilizing node-downloader-helper (and my package.json): https://gist.github.com/ginsm/694fc33f8b32e60d79e80357b7ab46f1

I commented out any console.* in my program to see if I was accidentally logging something but it still resulted in that strange output. :thinking:

hgouveia commented 2 years ago

Hello @ginsm , this is a really weird thing, i am not sure if related with an specific node.js version or is there any debug flags, or something related with *nix version of node? but i just tried to reproduce it using your code and for me is working fine,

image

Could you try to upgrade your node.js?, i was using 14.19.0 but you can try any different from your current one, btw there also a new version of the library you might want to upgraded it as well 2.1.0

ginsm commented 2 years ago

I updated node-downloader-helper (and esbuild) which seems to have resolved the issue (probably should've been one of the first things I did :sweat_smile:). It may have been something to do with esbuild? I don't know lol. Either way, it's working as it should now, thank you! :)