Disable keepalive by default

hgouveia / node-downloader-helper

A simple http file downloader for node.js

MIT License

253 stars 54 forks source link

Disable keepalive by default #92

Closed Half-Shot closed 1 year ago

Half-Shot commented 1 year ago

Node 19 introduces a new change which makes HTTP requests KeepAlive by default. This has the unintended side effect of making processes hang open, leading to eventual failure.

This change introduces two things:

We now disable keepalives by default on requests. This should be a no-op on older releases of Node where the flag does not exist.
We now test against Node.19 to protect against breakages in CI.

hgouveia commented 1 year ago

@Half-Shot thanks for your contribution, i will do some others fixing before release a new version and let you know when is released, no real ETA but i will try to be this week

Half-Shot commented 1 year ago

Thanks!

hgouveia commented 1 year ago

@Half-Shot published on v2.1.5, although i needed to made some changes since it affected others functions that made it fails, i also added some unit test