hgrecco / numbakit-ode

Leveraging numba to speed up ODE integration
Other
68 stars 3 forks source link

Fixed events page format #18

Closed DhruvSondhi closed 3 years ago

DhruvSondhi commented 3 years ago

Hello, I am very happy to see that we had made some progress with the events parameter & restructuring of DOP853 function. I thought that the current formatting of the page was off but I sent this PR just to make it better ... In my opinion looks much better & do let me know if I can help with anything else or with any implementation (though I am not that knowledgable in this sense now but I can always learn :) ) PS: There is some warning in the build for the docs ... I will try to fix them but this is unrelated to currect changes 😉

hgrecco commented 3 years ago

Thanks for the PR. A few things that I have pending:

And, this is a debatable issue, a solve_ivp function to easy migration from SciPy. I think it is not a good idea, but it is something to discuss.

DhruvSondhi commented 3 years ago

Sure... all these pending stuff looks awesome to work with & I will try my best to help complete this :)