search

hgrecco / pint-pandas

Pandas support for pint
Other
172 stars 42 forks source link

Rename module #1

Closed andrewgsavage closed 5 years ago

andrewgsavage commented 5 years ago

Running import pint-pandas doesn't work. Seems hyphens aren't recommended in module names. Can the module be renamed to pintpandas or similiar?

hgrecco commented 5 years ago

I like the way many packages do it. The github and package name has a hyphen but the package name does not (either skip them or replace them by underscore).

See for example: https://github.com/jgelens/gevent-websocket/tree/master/geventwebsocket https://github.com/lepture/flask-wtf https://github.com/scikit-image/scikit-image

andrewgsavage commented 5 years ago

Cool, thanks for the examples

hgrecco commented 4 years ago

I have changed the internal package name from pintpandas to pint_pandas as I think it will make easier to read future extensions (e.g. pint_dask, etc). I still need to fix the import in Pint