hgrecco / pint-pandas

Pandas support for pint
Other
166 stars 41 forks source link

Bugfix/fix 165 fill value must be scalar #187

Closed burnpanck closed 1 year ago

burnpanck commented 1 year ago
andrewgsavage commented 1 year ago

Is that the only place you encouter issues with force_ndarray_like = True? Would it be worth running all the pandas extension tests with force_ndarray_like = True?

burnpanck commented 1 year ago

Indeed, it may be reasonable to run the whole test-suite both with and without force_ndarray_like = True. Without this fix, many of the tests fail, but it always appeared to be the same error; missing values is an important feature within pandas. I think all issues may be fixed now, but I actually didn't run the whole test-suite with that flag after the fix at all. Do you know of a good way of passing a "feature flag" to a global pytest fixture, so that we can just simply run the whole test-suite twice?

andrewgsavage commented 1 year ago

I'm not aware of one, and the options I found googling didn't look suitable. I'll open a new issue for it.

andrewgsavage commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.