Closed MichaelTiemannOSC closed 11 months ago
Pandas 2.1rc0 has been released: https://github.com/pandas-dev/pandas/releases/tag/v2.1.0rc0
you can add the 2.1rc to https://github.com/hgrecco/pint-pandas/blob/bf84e37ed13d032a13edec948c1990909d920dec/.github/workflows/ci.yml#L11C10-L11C10 to get CI to test against it
I see that while these changes run happily with later versions of Pint and Pandas, there are many errors in the CI/CD system for Pandas 2.0.2 and Pint 0.21.3. I'll look at those and see how much of a gap there is to bridge, or whether these changes really are only for 2.1 and beyond.
Looking at Pandas 2.0.3 failures:
na_action
is not None. I'll add a pytest.skip
rule to skip the ignore
case when Pandas version < 2.1.check_opname
we can add (back) the missing exc
parameter that was removed when Pandas 2.1 refactored this interface.I'll update this list with other problems I find, or rewrite text to describe how the fixes were implemented (as a start for the WhatsNew).
this is looking great, thanks for putting this together.
Just needs adding the 2.1rc to the CI and a changes note
Ugh..the map changes worked for Pandas 2.1, but need fixing for 2.0.2. I'm on it...
bors r+
Build succeeded!
The publicly hosted instance of bors-ng is deprecated and will go away soon.
If you want to self-host your own instance, instructions are here. For more help, visit the forum.
If you want to switch to GitHub's built-in merge queue, visit their help page.
pre-commit run --all-files
with no errorsCI/CD doesn't quite work yet because we don't have a Pandas 2.1 rc to point to. But comments are welcome!