search

hgrecco / pint-pandas

Pandas support for pint
Other
166 stars 40 forks source link

follow up from #237 & #239 #240

Open mutricyl opened 5 days ago

mutricyl commented 5 days ago

This is a follow up from pandas nightly build CI job introduction. The following tests have been skipped to get green light workflow for #239. They need to be fixed.

Looks like also that unique function was inducing errors in tests but this was unexpectedly solved. It might be worth to investigate this a little bit.

skipped tests:

  • test_pandas_extensiontests.py::TestPintArray::test_arith_frame_with_scalar : tests with "radd", "rsub", "rmul", "rtruediv", "rpow" are not working with pandas 3
  • test_issues.py::TestIssue80::test_div : pandas 3 is so fast that _timeit returns 0
  • test_pandas_extensiontests.py : all test including complex are skipped due to NumpyExtensionArray issue in pandas take function https://github.com/pandas-dev/pandas/issues/59177

all temporary skip are marked by GH #239

Originally posted by @mutricyl in https://github.com/hgrecco/pint-pandas/issues/239#issuecomment-2208856625

Looks like there's a unique function issue similar to the take issue

pint_pandas/testsuite/test_pandas_extensiontests.py::TestPintArray::test_value_counts_with_normalize[float] - TypeError: unique requires a Series, Index, ExtensionArray, or np.ndarray, got NumpyExtensionArray. FAILED

Originally posted by @andrewgsavage in https://github.com/hgrecco/pint-pandas/issues/239#issuecomment-2209347877

mutricyl commented 4 days ago

https://github.com/pandas-dev/pandas/issues/59177 was resolved so complex may be allowed again for pandas >= 3