search

hgrecco / pint-pandas

Pandas support for pint
Other
172 stars 42 forks source link

Move files from pint to pint-pandas + Duck typed PintType #3

Closed andrewgsavage closed 5 years ago

andrewgsavage commented 5 years ago

This PR moves the pandas interface files from pint to this repo, and stores the units in the PintType as opposed to storing a quantity in the PintArray previously.

I've updated the example notebook to use the duck typed PintType. https://github.com/andrewgsavage/pint-pandas/blob/duck_typed/notebooks/Pandas_support.ipynb (This uses my pint branch, https://github.com/hgrecco/pint/pull/746/commits/61b44aec550c7ff34c9b20fb3000c8d19fc04706)

The pytest Tests are run in here and passing again, bar the xpassed ones. Haven't looked at coverage and not sure how it works!

hgrecco commented 5 years ago

This is progressing nicely. Please ping me when you want me to merge or look at it in more detail.

andrewgsavage commented 5 years ago

@hgrecco I think this is ready to look at.

I've got the coverage running, but not sure how to get it to compare to previous builds

hgrecco commented 5 years ago

This looks good to me. I think you need to squash it into two or three commits (testing, implementationa and setup) and include in the commit messsage the main idea behind the implementation.

Then I merge it and we can support pandas in 0.9.1

andrewgsavage commented 5 years ago

@znicholls would you like the tests and notebooks again? I think that's how we had it before. Could you give me a hand with the commands for squashing / removing the tests/notebooks?

Ah there's a release of pandas out now so can use that

andrewgsavage commented 5 years ago

@hgrecco Could you turn travis on here?

hgrecco commented 5 years ago

@andrewgsavage done

znicholls commented 5 years ago

@znicholls would you like the tests and notebooks again? I think that's how we had it before. Could you give me a hand with the commands for squashing / removing the tests/notebooks?

Yep sure! There's a few issues to cover so I've put them in #6, #7 .

In terms of workflow, I'll make PRs into andrewgsavage/pint-pandas. I'll add a PR with the new files into https://github.com/hgrecco/pint-pandas/pull/5 now