search

hgtonight / Application-Yaga

Yet Another Gamification Application is a Garden application that provides a gamification platform for Vanilla Forums and other Garden applications.
GNU General Public License v2.0
28 stars 23 forks source link

guest reactions permitted, causing warnings on display. #86

Closed replyPUSH closed 9 years ago

replyPUSH commented 9 years ago

https://github.com/hgtonight/Application-Yaga/blob/master/controllers/class.reactcontroller.php#L79

will allow for UserID = 0

later on on display you use Gdn::UserModel()->GetID($Reaction->UserID); This user doesn't exist so neither do its properties.

Turn debug notices on they are helpful, in trapping this type of bug.

x00 commented 9 years ago

sorry posted under wrong user.

x00 commented 9 years ago

guest reactions would be widely open to abuse anyway.

x00 commented 9 years ago

for some reason it is has only created the view permissions. There are no Add permissions for Guest roles, but there are add permissions for members.

The lack of the add permission is no barrier.

x00 commented 9 years ago

I eliminated the problem by forcing the running of structure.

hgtonight commented 9 years ago

This was due to an upgrade without running the structure update?

x00 commented 9 years ago

I don't think so, though someone had messed with the version.