Open dvolgyes opened 6 years ago
Hi,
It would make the code a bit more readable, if you would apply some PEP8 guidelines. I quite recommend autopep8 which can make changes automatically, e.g. removing non-empty blank lines (blank lines with only whitespaces).
I also quite recommend flake8 which can check the code quality for frequent mistakes, or non-pythonic idioms, especially with bugbear plugin. See: autopep8: https://pypi.python.org/pypi/autopep8 flake8: https://pypi.python.org/pypi/flake8 flake8-bugbear: https://pypi.python.org/pypi/flake8-bugbear
(In general, I did not find anything problematic, it is just style, but it also does not take more than a few minutes to make it tidy.)
Hi David,
Thank you for taking the time to read the code and give feedback. It is extremely appreciated and useful since I am not that used to pep8 style.
I gave it a look and formatted the code with autopep8.
Hi,
It would make the code a bit more readable, if you would apply some PEP8 guidelines. I quite recommend autopep8 which can make changes automatically, e.g. removing non-empty blank lines (blank lines with only whitespaces).
I also quite recommend flake8 which can check the code quality for frequent mistakes, or non-pythonic idioms, especially with bugbear plugin. See: autopep8: https://pypi.python.org/pypi/autopep8 flake8: https://pypi.python.org/pypi/flake8 flake8-bugbear: https://pypi.python.org/pypi/flake8-bugbear
(In general, I did not find anything problematic, it is just style, but it also does not take more than a few minutes to make it tidy.)