hgzimmerman / rocket-file-cache

An in-memory file cache for the Rocket web framework
MIT License
22 stars 6 forks source link

Get rid of Cache::new(). Either replace with default, or don't replace it at all. #20

Closed hgzimmerman closed 6 years ago

hgzimmerman commented 6 years ago

Currently, Cache::new() makes some opinionated choices for the user, which should be covered by a Default impl instead.

By default:

Possibly a warning should be logged indicating that users of the method should use the builder instead.


Alternatively:

Don't replace it at all. Force users to use the builder, which would have the same outcome as the Default impl anyways.

hgzimmerman commented 6 years ago

Has been deprecated. Will remove for 1.0.0 release.

hgzimmerman commented 6 years ago

Being removed for 1.0.0-beta release.