search

hh / windows-fromscratch

Windows Vagrant VM from scratch
97 stars 21 forks source link

promised pull request that fixed my windows installation problems #2

Closed marsmensch closed 11 years ago

marsmensch commented 11 years ago

added basic auth parameter for winrm client to fix installation, tested with both windows installation types

jedi4ever commented 11 years ago

hey @marsmensch could you send the pull request to veewee ? Also encrypting the password is not a good thing I think.

marsmensch commented 11 years ago

Yes, that was the first thing planned for tomorrow.

What is the problem with the encrypted password? I did not touch any other options.

Am 24.01.2013 um 13:23 schrieb Patrick Debois notifications@github.com:

hey @marsmensch https://github.com/marsmensch could you send the pull request to veewee ? Also encrypting the password is not a good thing I think.

— Reply to this email directly or view it on GitHubhttps://github.com/hh/windows-fromscratch/pull/2#issuecomment-12648809.

hh commented 11 years ago

Thanks for squashing that bug @marsmench !

I think you made you changes against an earlier release, when I was using encrypted pass. Using a non-encrypted version makes it easier to understand and make changes etc.

hh commented 11 years ago

https://github.com/hh/windows-fromscratch/commit/4a497f39b reverting to plain text passwords.

marsmensch commented 11 years ago

You are welcome! I thought i synced with your master before branching, but i guess i messed it up doing it in a hurry.

Will have a look at it tomorrow and also create a pull request for upstream/veewee.

Thanks for your work!

Am 24.01.2013 um 17:27 schrieb Hippie Hacker notifications@github.com:

Thanks for squashing that bug @marsmench !

I think you made you changes against an earlier release, when I was using encrypted pass. Using a non-encrypted version makes it easier to understand and make changes etc.

— Reply to this email directly or view it on GitHubhttps://github.com/hh/windows-fromscratch/pull/2#issuecomment-12659348.