search

hhaccessibility / hhaccessibility.github.io

http://hhaccessibility.github.io/main/
7 stars 41 forks source link

Inconsistency on location report page! #670

Closed singlaneha2205 closed 5 years ago

singlaneha2205 commented 5 years ago

While going through different locations I noticed that we have inconsistency on location page. For some locations we have buttons displayed as Suggest Updates, Accommodation and so on, while for others we have icons for the same features. I think it should be uniform across the application. Please refer to below screenshots for further reference. Buttons with names: untitled

Buttons With Icons: untitled

joshi1983 commented 5 years ago

Those buttons can use some improvements but the decision between icons and words is intended to be based on a mixture of available space and the number of buttons. In those screenshots, there are more buttons in the case that uses icons. The main problem we want to prevent with deciding to use the icons is having the buttons wrap to new lines or crowd out the address and web link.

I'll look into it some more since the new "Update Suggestions" button might have changed how it should behave.

joshi1983 commented 5 years ago

I can't think of a better way to handle these buttons. The issue was originally made based on a misunderstanding of how the icons and button text are determined rather than it really being a bug. I think it is working as well as possible.