search

hhaccessibility / hhaccessibility.github.io

http://hhaccessibility.github.io/main/
7 stars 41 forks source link

#621 Show caps lock on sign in #673

Closed M4ttoF closed 5 years ago

M4ttoF commented 5 years ago

updated the PR and now look just like you asked image

joshi1983 commented 5 years ago

The updates to app/package-lock.json aren't clearly needed. They were commited with the commit that says "Looks better now and includes icon". If you remove those changes, this pull request should be ready for merge.

Ideally, undo the changes and squash or fixup them into the "Looks better now and includes icon" commit to save a little space and help the 'git blame' feature point out more useful commits.

If want an idea for how to undo the changes, I would:

  1. git checkout the master branch.
  2. Copy the app/package-lock.json file to another file.
  3. git checkout your issue branch.
  4. Delete the app/package-lock.json file and rename the other file to app/package-lock.json.
  5. Commit that change to app/package-lock.json.
  6. git rebase -i master
  7. fixup your new commit up into "Looks better now and includes icon"