search

hhaccessibility / hhaccessibility.github.io

http://hhaccessibility.github.io/main/
7 stars 41 forks source link

Load Recovery Reply To Email from .env file #734

Closed joshi1983 closed 5 years ago

joshi1983 commented 5 years ago

We don't want anyone's email address tracked in the repository. We want them maintained in the .env file.

For now, the reply to email address is hard coded in PasswordRecoveryController.php.

joshi1983 commented 5 years ago

@hari2684 did you want to take this on?

hariharan2684 commented 5 years ago

ok Will take it.

joshi1983 commented 5 years ago

Nice. Thanks.

Since some changes were merged that affected files you'll update in this issue, it is important to get latest before working on this.

There are instructions on how to get the latest merged changes at: https://github.com/hhaccessibility/hhaccessibility.github.io/wiki/git-commands

image You can skip the step of adding an upstream remote since you've already done that. I crossed it out in the screenshot to be clear. issue-734 would also be a better branch name than the one in the screenshot so it identifies the related issue.

joshi1983 commented 5 years ago

Thanks Hariharan. It has been merged and deployed.

I'm closing this since I tested the changes and there isn't much reason to wait for a third person to test these changes.