hhanh00 / zwallet

Zcash and Ycash light shielded wallet
https://ywallet.app
MIT License
42 stars 20 forks source link

History appears broken for some transactions (unshielded ones, but also for some shielded ones without notes), on Desktop (Linux) #130

Closed LindaFerum closed 5 months ago

LindaFerum commented 7 months ago

Subject of the issue

Sometimes incoming transactions just don't get listed in history. Transactions to naked addresses are particularly affected but sometimes shielded transactions (Orchard) also end up affected.

The coins arrive in the account alright and are spendable, it's just the history display that never "sees" them

Transactions that come with a proper note don't seem to ever be affected.

Your environment

Reproduced on v1.5.1+14 and v1.5.2+12

Debian 11 and 12 , bare metal and VM

Steps to reproduce

Receive some Zcash. Especially to a non-shielded address.

If using shielded address, omit note (transactions with (non-empty) notes on them seem to not be affected)

Expected behaviour

All incoming transactions to be properly faithfully reflected in history

Actual behaviour

Some transactions (as described above) don't get reflected in history

hhanh00 commented 7 months ago

The issue is upstream. The server prunes t2t tx from the compact blocks so we have to fetch transparent data separately. The API returns balances correctly but the full history is a mess.

If using shielded address, omit note (transactions with (non-empty) notes on them seem to not be affected)

I would need more info.

LindaFerum commented 7 months ago

Basically, making a shielded transaction without any notes whatsoever can also result in the transaction not showing up in history. It doesn't seem to be happening consistently so I'm not sure I can provide more useful reproduction instructions other than "make an orchard shielded transaction, put nothing into the note"

So far I just always put in notes and it's working out okay. I'm just mildly concerned that a few people I want to "convert" to using Zcash will freak out if some of their transactions (particularly shielded ones) get unlisted from history, I'll be the one dealing with the freak out and explaining the need to be charitable about complex software behavior :3

hhanh00 commented 7 months ago

Would you be ok with sharing the viewing key to an account that shows this issue? I wasn't able to reproduce this problem.

Edit: to be clear, transactions that have no shielded inputs and no shielded outputs to the account (usually these are change) cannot be detected. The balance of the account should be correct though.

hhanh00 commented 5 months ago

Closing due to inactivity

LindaFerum commented 4 months ago

Hi! I'd like to get back to this (sorry for long delay @hhanh00 , business stuff), how do I send you the view keys privately?