hhannine / superpaper

A cross-platform multi monitor wallpaper manager.
MIT License
1.15k stars 47 forks source link

Infinite spinning cursor in Windows v2.2.1, no changes saved or applied, but no crash either #136

Closed nonplayer closed 1 year ago

nonplayer commented 1 year ago

Describe the bug Using version 2.2.1 on Windows 10 Pro 22H2, either portable or installed, any attempt to save profile or apply changes results in infinite spinning cursor with no visible action. Profiles do not get saved, wallpapers do not get applied.

However, there is no crash or "not responding" message. The app continues to run, the tray icon remains, and the Settings menu can be updated and changed as normal. Only the Wallpaper Config menu seems affected.

I tried this on a machine previously running 2.1.1, as well as a brand new machine without a prior Superpaper version. On both machines, 2.2.1 resulted in this issue. On both machines, either reverting to or subsequently installing anew with 2.1.1 resulted in normal expected operations.

To Reproduce

  1. Install 2.2.1. on Windows
  2. Attempt to create a new profile
  3. Attempt to either Save profile or Apply changes

Results: infinite cursor spin, no change, but no crash.

Expected behavior

Saving a profile and applying changes should have the normal expected results of said actions.

Desktop (please complete the following information):

hhannine commented 1 year ago

I was able to reproduce this: Traceback (most recent call last): File "\superpaper\gui.py", line 1145, in onSave self.parent_tray_obj.update_hotkey(tmp_profile.name, old_profile.hk_binding, tmp_profile.hk_binding) AttributeError: 'NoneType' object has no attribute 'hk_binding' This is a bug in a recent change.

Luckily the issue is with the binding of the hotkey of the newly saved profile, and the profile is actually saved. If you shutdown superpaper and run it again, you should be able to start the newly saved profile.

hhannine commented 1 year ago

Also you can run the previous 2.1 version and should not have any issues on Windows.

hhannine commented 1 year ago

This is now resolved and fix will be in next release. Meanwhile you can run Superpaper 2.1