search

hharnisc / hypercwd

Opens new tabs with the same directory as the current tab in Hyper
MIT License
384 stars 39 forks source link

Opening a new tab throws an uncaught exception #32

Open Mohamed3on opened 6 years ago

Mohamed3on commented 6 years ago

This issue seems to happen only with hypercwd installed, the original issue is here: https://github.com/zeit/hyper/issues/2175

GabeDuarteM commented 6 years ago

That is happening to me too.

Apparently, it happens when something is running on that tab, for example, when you leave webpack-dev-server running and try to open a new tab, or when you have your tests running (in watch mode) and try to open a new tab, etc.

hharnisc commented 6 years ago

Is this still happening with Hyper 2.X and hypercwd 1.2.3?

This might be fixed now since hypercwd has been removed from stdout stdin path

dcalhoun commented 6 years ago

@hharnisc this error does not appear to occur for me in hyper@2.0.0.

N0xFF commented 6 years ago

@hharnisc its still appear on Hyper 2.1.0-c1 and hypercwd 1.2.3 when I use shell: 'C:\\Windows\\System32\\bash.exe'

Uncaught Exception:
Error: Unable to start terminal process: CreateProcess failed
    at new WindowsPtyAgent (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\node_modules\node-pty\lib\windowsPtyAgent.js:25:24)
    at new WindowsTerminal (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\node_modules\node-pty\lib\windowsTerminal.js:45:24)
    at spawn (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\node_modules\node-pty\lib\index.js:27:12)
    at Session (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\session.js:53:18)
    at initSession (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\ui\window.js:102:24)
    at Server.Window.rpc.on.options (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\ui\window.js:105:7)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at Server.ipcListener (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\rpc.js:33:11)
    at emitTwo (events.js:125:13)
MikeRatcliffe commented 4 years ago

Still an issue in Hyper 3.0.2... at least when using WSL.