hharnisc / hypercwd

Opens new tabs with the same directory as the current tab in Hyper
MIT License
384 stars 39 forks source link

1.2.2 now breaks hyper: "...\hypercwd\setCwd.js:25 Uncaught ReferenceError: tabId is not defined" #43

Closed campbellgoe closed 6 years ago

campbellgoe commented 6 years ago

Hypercwd 1.2.2 completely breaks hyper. The dev console outputs this:

Plugin hypercwd (1.2.2) loaded. index.html:35 total init time 2380.575 C:\Users\.hyper_plugins\node_modules\hypercwd\setCwd.js:25 Uncaught ReferenceError: tabId is not defined at windowsSetCwd (C:\Users\.hyper_plugins\node_modules\hypercwd\setCwd.js:25) at C:\Users\u.hyper_plugins\node_modules\hypercwd\windowsActionHandler.js:27 at bundle.js:1 at bundle.js:1 at bundle.js:1 at dispatch (bundle.js:1) at Object.effect (bundle.js:1) at bundle.js:1 at bundle.js:1 at bundle.js:1

Hyper works with 1.2.1 and below.

n1340t commented 6 years ago

Same issue, I have to uninstall hyercwd for temporarily use.

hharnisc commented 6 years ago

Could you list your hyper version and any other pluggins you're using @GCDeveloper and @cyborg103

n1340t commented 6 years ago

I just uninstall hypercwd so I don't really know hypercwd's version but I am pretty sure it is the latest version because I have tried updating plugin but Hyper still doesn't work. My hyper version is 2.0. I also use "hypersearch" and "hyperpower"

campbellgoe commented 6 years ago

The only plugin I am using is hypercwd. Hyper works when i set it to #1.2.1 or uninstall the plugin completely, but the latest update yesterday (1.2.2) seems to cause this issue because I have been using hypercwd for a few months now just fine.

Stanzilla commented 6 years ago

Are you guys trying to get this to work on WSL? It's just a guess but if you are, it won't work anyway, see https://github.com/hharnisc/hypercwd/issues/16.

Please state more info about your environment and use case when you report an issue :)

campbellgoe commented 6 years ago

I am on Windows 10 and here is my hypercwd config:

//hypercwd config
hypercwd: {
    initialWorkingDirectory: "C:/path/to/my/project"
}

I have also used "C:\\path\\to\\my\\project"

n1340t commented 6 years ago

My is window 10 Home. My shell is default window command prompt. Even I close hyper and reopen again, the app fail to start with latest hypercwd version. Hope these info help

asyncore commented 6 years ago

Hello! I created a PR to fix this: https://github.com/hharnisc/hypercwd/pull/44

hharnisc commented 6 years ago

@asyncore's fix has been publish as version 1.2.3 thanks so much :raised_hands: