search

hharnisc / hypercwd

Opens new tabs with the same directory as the current tab in Hyper
MIT License
384 stars 39 forks source link

Fix missing reference (tabId) in windowsSetCwd() #44

Closed asyncore closed 6 years ago

asyncore commented 6 years ago

Hi, Not sure if this is the best fix but this change does the job. The body of windowsSetCwd has been copied from index.js. However the signature has changed, and tabId is no longer passed as an argument. Since the caller already sets curTabId as action.uid, I propose a fix to replace missing tabId with action.uid, although it also makes sense to remove the tabId === curTabId condition altogether, because now it will always be true.

reevik commented 6 years ago

thanks!

danyfoo commented 6 years ago

@bagdemir Is any posibility to merge this commit to fix this bug?

panmona commented 6 years ago

@hharnisc or @bagdemir -> Can you merge this PR? Would be greatly appreciated!

hharnisc commented 6 years ago

Hey everyone :wave:

So sorry for the delay here, I've been away on vacation :palm_tree: Going to merge this fix and publish a new release now.

It's become clear this project needs another maintainer, specifically one that lives on windows. Would anyone be up for that? I rely on this for Linux (OS X is same code path for now), so I can promise that will work.

hharnisc commented 6 years ago

Published as version 1.2.3

hharnisc commented 6 years ago

Thank you for the fix @asyncore :raised_hands:

panmona commented 6 years ago

Wow this was fast. Thanks @hharnisc! Works well for me now.

kmccmk9 commented 6 years ago

@hharnisc I use Windows primarily and use hyper everyday. I can do maintenance and pull request checking to make sure it works under Windows.