search

hharnisc / hypercwd

Opens new tabs with the same directory as the current tab in Hyper
MIT License
384 stars 39 forks source link

Fix: Broken tabs in Hyper 3 (canary.1) #60

Closed frankieshakes closed 5 years ago

frankieshakes commented 5 years ago

Fixes issue with tabs not working in Hyper v3 (canary.1)

chabou commented 5 years ago

It could be better to ensure backward compatibility to ensure a better migration path.

I would test if promiseExec returns a string or an object.

juancampa commented 5 years ago

I can confirm this works on v2 and v3 (with @chabou's suggestions)

frankieshakes commented 5 years ago

Perfect. I'll get those changes added ASAP. Thanks for the suggestions @chabou!

hharnisc commented 5 years ago

Thanks for the fix @juancampa and @chabou 🙌

hharnisc commented 5 years ago

Going the publish this as 1.3.0

rauchg commented 5 years ago

Thanks @frankieshakes – you are the hero we need

hharnisc commented 5 years ago

I forgot to mention you too @frankieshakes -- thank you so much for this pr 🙌

frankieshakes commented 5 years ago

My pleasure @rauchg and @hharnisc! Glad I could contribute... if there's anything else that needs fixing, hit me up. I'm more than happy to help out!