search

hharnisc / meteor-accounts-admin-ui-bootstrap-3

A roles based account management system using bootstrap 3 for Meteor
MIT License
56 stars 55 forks source link

PR featuring configuration, optional impersonation support, and optional last login support #17

Open andylash opened 10 years ago

andylash commented 10 years ago

Hi,

I meant to do this before, but got a bit distracted, but I needed last login support today, so I figured I try and do it in a useful way for the main branch. I added a general configuration facility, but made it optional so I thought that would be more in the spirit of what library's general feel is. Anyway, happy to hear feedback if you don't like the approach.

cheers, andy

hharnisc commented 10 years ago

I finally got some time to test the features you've proposed in the request. Everything seems to be working for me -- I'm going to make a few tweaks to the UI and mess around with the configuration stuff. After seeing user-status it seems more like an opt out rather than opt in (seems useful). Still debating on wether the impersonation stuff should be opt out or in.

andylash commented 10 years ago

User-status is pretty awesome actually, but it does depend on 2 other packages user-status and roles, so it's more heavy. Impersonation is something I use almost constantly for support and I really like it, but to make it have meteor magic you have to put your subscription in an autorun.

Anyway, open to however you want to go here.

cheers, andy

On Wed, Jun 11, 2014 at 11:05 PM, Harrison Harnisch < notifications@github.com> wrote:

I finally got some time to test the features you've proposed in the request. Everything seems to be working for me -- I'm going to make a few tweaks to the UI and mess around with the configuration stuff. After seeing user-status it seems more like an opt out rather than opt in (seems useful). Still debating on wether the impersonation stuff should be opt out or in.

— Reply to this email directly or view it on GitHub https://github.com/hharnisc/meteor-accounts-admin-ui-bootstrap-3/pull/17#issuecomment-45833157 .

hharnisc commented 9 years ago

How has this been working out for you in your project? I pull this locally and played around with it and it all looks pretty great. Do you mind if I merge in these changes?

andylash commented 9 years ago

Oh sure, absolutely. I actually have a ton of other changes (though roles are currently broken in my fork as I haven't gotten around to dealing with roles within groups, a roles feature I'm now using). Stuff like server side pagination.

Anyway, feel free to merge or if you like I can do some clean up and then give you a newer cleaner PR.